Replace ITelemetryActivator with ITelemetryModule #3009
+8
−181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
ITelemetryActivator
withITelemetryModule
so we can have more flexibility with configuration. For example, with this change we can set Managed Identity credentials instead of only setting Application Insights relevant settings.For context:
ITelemetryActivator
: Used to activate or create telemetry objects. It also initializes the telemetry client for distributed tracing, allowing settings to be verified and adjusted during initializationITelemetryModule
: Used to initialize and configure telemetry modules fromTelemetryConfiguration
. It ensures that telemetry modules are properly set up to collect and send data using the same configuration.Also, in this PR, we remove some log statements and checks. With
ITelemetryActivator
, we checked if the customer was providingAPPINSIGHTS_INSTRUMENTATIONKEY
and/orAPPLICATIONINSIGHTS_CONNECTION_STRING
and logged different warnings based on the configuration. WithITelemetryModule
, it automatically has the configuration in theTelemetryConfiguration
object, so we no longer need to check for these configurations.Resolves #2870
Pull request checklist
pending_docs.md
release_notes.md
/src/Worker.Extensions.DurableTask/AssemblyInfo.cs